Re: [PATCH] Fix c/69643, named address space wrong-code

[Richard Biener <richard dot guenther at gmail dot com>]

On Thu, Feb 4, 2016 at 11:35 PM, Richard Henderson <rth@redhat.com> wrote:
> On 02/05/2016 08:59 AM, Richard Biener wrote:
>>>
>>> This version fails to fall through to the next code block when
>>>    (1) Both types are pointers,
>>>    (2) Both types have the same address space,
>>> which will do the wrong thing when
>>>    (3) The pointers have different modes.
>>>
>>> Recall that several ports allow multiple modes for pointers.
>>
>>
>> Oh, I thought they would be different address spaces.
>
>
> They probably should be.
>
>> So we'd need to add a mode check as well.
>
>
> Yes.  But why make this one expression so complicated that it's hard to
> read,
> as opposed to letting the existing code that checks modes check the mode?

Works for me.

>> I hope we don't have different type bit-precision with the same mode for
>> pointers here?
>
>
> Not that I'm aware.  ;-)
>
>
> r~