Re: [PING] Add new mexecute-only arm option.

[Sandra Loosemore <sandra at codesourcery dot com>]

On 02/02/2016 02:06 AM, mickael guene wrote:
> Hi All,
>
>   Ping for following thread :
>
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html

Two comments:

(1) MIPS has had a similar option for quite some time called 
-mcode-readable=.  It might be less confusing to use a similar name for 
the ARM option with the similar reversed sense to -mexecute-only, even 
if it doesn't need to be a tristate flag like for MIPS.

(2) I suggest changing the help string for the command line option

> +
> +mexecute-only
> +Target Report Var(target_execute_only) Init(0)
> +Forbid load into text sections.

to use the same wording as the documentation in the manual:

> +@item -mexecute-only
> +@opindex mexecute-only
> +Disable read memory access inside code sections.  Only code fetching is
> +allowed.
> +This option is off by default.
> +

Or at least, "load into text sections" is confusing.  (You load *from* 
the text section, not *into* it, right?)

-Sandra