Re: genattrab.c generate switch

[Jesper Broge Jørgensen <jesperbroge at gmail dot com>]

On 19/01/16 13:18, Bernd Schmidt wrote:
> On 01/18/2016 11:44 PM, Jesper Broge Jørgensen wrote:
> > I found a formatting tool called uncrustify that comes with a gnu style
> > config
> > https://github.com/bengardner/uncrustify/blob/master/etc/gnu-indent.cfg
> > that needed a few tweaks to format code that looked what is already in
> > gcc/genattrtab.c
> >
> > The tweaks was:
> >
> > indent_with_tabs = 2 // instead of 0
> > sp_func_def_paren     = add // instead of remove
> > sp_func_proto_paren  = add // instead of remove
> > sp_func_call_paren     = add // instead of remove
> >
> > So now the code should be correctly formatted.
>
> Best to get that right when editing, though. emacs defaults to GNU 
> style and other editors can also be tweaked.
>
> > Do i send in a new patch or just respond to the old one with the new
> > changes?
>
> Usually best to send updated patches (as text/plain attachment to 
> avoid word-wrapping and other whitespace damage).
>
> > I have also followed instructions at
> > https://gcc.gnu.org/ml/gcc/2003-06/txt00010.txt to get copyright
> > assignment though i have not yet received a reply.
>
> Ok, we'll have to wait for that.
>
>
> Bernd
I have finally received the copyright assignment it is currently on its 
way over the atlantic via snail mail.
In the meantime i have attached the the refomatted patch here hoping it 
could be reviewed while we wait.

Attachment: gcc_patch_reformatted.patch
Description: Text document