This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap on i686 (PR middle-end/69542)
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Vladimir Makarov <vmakarov at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 28 Jan 2016 12:58:59 -0800
- Subject: Re: [PATCH] Fix bootstrap on i686 (PR middle-end/69542)
- Authentication-results: sourceware.org; auth=none
- References: <20160128201751 dot GH3017 at tucnak dot redhat dot com>
On 01/28/2016 12:17 PM, Jakub Jelinek wrote:
> The recent lra-remat.c change broke bootstrap for me on i686,
> with comparison failure on simplify-rtx.o.
> Below is a reduced testcase. debug insns really should not affect
> remat decisions, before the recent changes set_bb_regs should be always a
> nop on debug insns (they don't change any registers, and don't have REG_DEAD
> notes). But they could have subregs of multiword regs.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2016-01-28 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/69542
> * lra-remat.c (calculate_local_reg_remat_bb_data): Only consider
> non-debug insns.
>
> * gcc.dg/torture/pr69542.c: New test.
Looks good to me. Thanks.
Can you please apply to gcc-5-branch too, since I've
already applied the 69449 patch there.
r~