This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, Jason Merrill <jason at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Jan 2016 04:47:04 -0800
- Subject: Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)
- Authentication-results: sourceware.org; auth=none
- References: <20160113152650 dot GJ25528 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1601131852060 dot 17296 at digraph dot polyomino dot org dot uk> <20160113195616 dot GL25528 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1601132311300 dot 9689 at digraph dot polyomino dot org dot uk> <20160120113151 dot GY25528 at redhat dot com> <20160127072601 dot GP25528 at redhat dot com> <56A8F82C dot 1050903 at redhat dot com> <20160127174509 dot GB25193 at redhat dot com>
On Wed, Jan 27, 2016 at 9:45 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Wed, Jan 27, 2016 at 10:02:36AM -0700, Jeff Law wrote:
>> On 01/27/2016 12:26 AM, Marek Polacek wrote:
>> >Ping.
>> >
>> >On Wed, Jan 20, 2016 at 12:31:51PM +0100, Marek Polacek wrote:
>> >>On Wed, Jan 13, 2016 at 11:11:52PM +0000, Joseph Myers wrote:
>> >>>The C front-end changes are OK.
>> >>
>> >>Jason, is the C++ part of this patch here
>> >><https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00866.html>
>> >>(which is identical to the change in the C FE) ok?
>> >>
>> >>Also, not sure about backporting this, maybe just to 5?
>> I'll go ahead and ack the C++ bits. This is fine for the trunk.
>
> Thanks.
>
>> WRT backporting, your call.
>
> I think I'll put it into GCC 5 (it's safe and should apply cleanly),
> but leave 4.9 alone.
>
> Marek
I got
FAIL: c-c++-common/vector-compare-4.c -Wc++-compat (test for
warnings, line 17)
FAIL: c-c++-common/vector-compare-4.c -Wc++-compat (test for
warnings, line 18)
FAIL: c-c++-common/vector-compare-4.c -Wc++-compat (test for
warnings, line 34)
FAIL: c-c++-common/vector-compare-4.c -Wc++-compat (test for
warnings, line 35)
on x86 on GCC 5 branch.
--
H.J.