This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite]: Disable some tests in gcc.dg/torture/pr68264.c for older glibcs


On Jan 27, 2016, at 12:58 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> 2016-01-27  Uros Bizjak  <ubizjak@gmail.com>
> 
>    * gcc.dg/torture/pr68264.c: Disable log1p test for glibc < 2.22
>    and expm1 test for glibc < 2.11.
> 
> Tested on x86_64-linux-gnu, CentOS 5.11 and Fedora 23.
> 
> OK for mainline?

So, unless we have a glibc style person that wants to comment further on it, I think the patch is Ok.

The only part I was worried about, is that you included defined(__GLIBC__) &&, and you did.  Darwin and newlib for example, won’t define that.  You also included the glibc bug number, which is excellent.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]