This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Handle error_mark_node in cp_fold (alt; PR c++/68357)
- From: Mike Stump <mikestump at comcast dot net>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Jan 2016 11:06:08 -0800
- Subject: Re: [C++ PATCH] Handle error_mark_node in cp_fold (alt; PR c++/68357)
- Authentication-results: sourceware.org; auth=none
- References: <20160126135624 dot GV3017 at tucnak dot redhat dot com> <20160126163906 dot GC3017 at tucnak dot redhat dot com>
On Jan 26, 2016, at 8:39 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Jan 26, 2016 at 02:56:24PM +0100, Jakub Jelinek wrote:
>> Another alternative would be to make sure tree folders don't introduce
>> error_mark_node (if it wasn't there already), but instead fold the call say
>> to build_int_cst (returntype, 0). The known cases that would need to change
>> are at least darwin_build_constant_cfstring and darwin_fold_builtin, but
>> maybe others.
>
> Here is the alternative (but it is unclear if other targets don't have
> similar issues in their folders).
So, Jason needs to make the decision on which patch he prefers.
If he prefers that error mark node not be generated this late, then the below patch is Ok.