This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [AARCH64][ACLE] Implement __ARM_FP_FENV_ROUNDING in aarch64 backend.


On 11/01/16 10:28, Marcus Shawcroft wrote:
On 11 January 2016 at 08:12, Bilyan Borisov <bilyan.borisov@foss.arm.com> wrote:

2015-XX-XX  Bilyan Borisov  <bilyan.borisov@foss.arm.com>

         * config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins): New
macro
         definition.

gcc/testsuite/

2015-XX-XX  Bilyan Borisov  <bilyan.borisov@foss.arm.com>

         * gcc.target/aarch64/fesetround-checking-baremetal.c: New.
         * gcc.target/aarch64/fesetround-checking-linux.c: Likewise.

for new test cases in gcc.target/aarch64 use the name convention here
https://gcc.gnu.org/wiki/TestCaseWriting, in this case:

fesetround_checking_baremetal_1.c
fesetround_checking_linux_1.c

If we are distinguishing between glibc/musl/bionic/uclibc then the use
of the name "linux" in the last test case would seem to be
inappropriate (all of glibc/musl/bionic and uclibc can be used on top
of a linux kernel). Suggest s/linux/glibc/ in the test case name.

Cheers
/Marcus

However, the test doesn't really look at whether we're using glibc vs musl/bionic/uclibc, only at whether we are targeting -linux-gnu or -none-elf.

Indeed, IIUC, the test would fail, if one (somehow) built a gcc using musl/bionic/glibc, as I'm not aware of us having a mechanism to detect that from the testsuite...

Just my two cents!

Alan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]