This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] testsuite/lib/multline.exp: show test name and line numbers
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: David Malcolm <dmalcolm at redhat dot com>, Bernd Schmidt <bschmidt at redhat dot com>
- Date: Tue, 29 Dec 2015 10:17:21 +0100
- Subject: Re: [PATCH] testsuite/lib/multline.exp: show test name and line numbers
- Authentication-results: sourceware.org; auth=none
Hello!
> Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu;
> I compared the results against a control build (of r231445), and
> the results were unchanged, other than the expected changes from
> the above, leading to
> - 92 PASS results changing name within g++.sum
> - 7 PASS results changing name within each of obj-c++.sum
> and objc.sum, and
> - 125 PASS results changing name within gcc.sum.
>
> OK for trunk for gcc 6?
>
> gcc/testsuite/ChangeLog:
> * lib/multiline.exp (_multiline_expected_outputs): Update comment.
> (dg-end-multiline-output): Capture line numbers within
> _multiline_expected_outputs.
> (handle-multiline-outputs): Access global $testname_with_flags
> and add it as a prefix to pass/fail results. Extract line numbers
> from $_multiline_expected_outputs and print them within pass/fail
> results, replacing the printing of $index. Consolidate the
> string prefix shared between pass/fail into a new local: $title.
It looks that this new functionality doesn't handle conditional
compilation, when
/* { dg-do compile { target { ! ia32 } } } */
is added to the testcase, such as in recently changed
gcc.target/i386/pr68473-1.c.
The directive is passed to the next testcase, leading to spurious
testsuite failures [1] in unrelated testcases.
[1] https://gcc.gnu.org/ml/gcc-testresults/2015-12/msg02761.html
Uros.