This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCHES, PING*5] Enhance standard DWARF for Ada
- From: Jason Merrill <jason at redhat dot com>
- To: Pierre-Marie de Rodat <derodat at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Cary Coutant <ccoutant at gmail dot com>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Wed, 16 Dec 2015 16:30:14 -0500
- Subject: Re: [PATCHES, PING*5] Enhance standard DWARF for Ada
- Authentication-results: sourceware.org; auth=none
- References: <55A76C7B dot 7080303 at adacore dot com> <55B0C74D dot 3040907 at adacore dot com> <55BB53F3 dot 1080101 at adacore dot com> <55BB56B1 dot 8080407 at adacore dot com> <55C5C54E dot 8050700 at adacore dot com> <55E4025B dot 3050309 at adacore dot com> <5626A05D dot 3090905 at adacore dot com> <564CE0F7 dot 4060801 at redhat dot com> <56531A3E dot 40504 at adacore dot com> <56538037 dot 7060900 at redhat dot com> <56542B0F dot 6040102 at adacore dot com> <5655FF72 dot 7030901 at redhat dot com> <5656FC6C dot 7040008 at adacore dot com> <566B3151 dot 4000209 at redhat dot com> <56712691 dot 4050709 at adacore dot com>
On 12/16/2015 03:53 AM, Pierre-Marie de Rodat wrote:
+ /* Called from finalize_size_functions for functions whose body is needed to
+ generate complete debug info. For instance, functions used to compute the
+ size of variable-length structures. */
+ void (* function_body) (tree decl);
Calling this "function_body" seems overly generic; let's call it
size_function and talk specifically about encoding the function body in
the debug info.
debug_nothing_rtx_insn, /* var_location */
+ debug_nothing_tree, /* var_location */
And this comment shouldn't be the same as the previous line.
+/* Helper for loc_descr_without_nops: free the location description operation
+ P. */
+bool
+free_loc_descr (const dw_loc_descr_ref &loc, void *data ATTRIBUTE_UNUSED)
Blank line between comment and function.
OK with those changes.
Jason