This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Splitting up gcc/omp-low.c?

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Thomas Schwinge <thomas at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 10 Dec 2015 12:26:10 +0100
Subject: Re: Splitting up gcc/omp-low.c?
Authentication-results: sourceware.org; auth=none
References: <20151207111758 dot GA24234 at virgil dot suse dot cz> <20151207112243 dot GF24234 at virgil dot suse dot cz> <20151209131930 dot GS5675 at tucnak dot redhat dot com> <87si3b4mk3 dot fsf at kepler dot schwinge dot homeip dot net> <5668638A dot 5030500 at redhat dot com> <20151210080835 dot GX5675 at tucnak dot redhat dot com>

On 12/10/2015 09:08 AM, Jakub Jelinek wrote:

On Wed, Dec 09, 2015 at 06:23:22PM +0100, Bernd Schmidt wrote:

On 12/09/2015 05:24 PM, Thomas Schwinge wrote:


In addition to that, how about we split up gcc/omp-low.c into several
files?  Would it make sense (I have not yet looked in detail) to do so
along the borders of the several passes defined therein?  Or, can you
tell already that there would be too many cross-references between the
several files to make this infeasible?


It would be nice to get rid of all the code duplication in that file. That
alone could reduce the size by quite a bit, and hopefully make it easier to
read.


What exact code duplication do you mean?

Functions that are near-identical with slight differences, or which havelarge sections of identical code. scan_omp_task vs scan_omp_parallel, orthe various expand_omp_for functions are examples.



Bernd

Follow-Ups:
- Re: Splitting up gcc/omp-low.c?
  - From: Jakub Jelinek

References:
- [hsa 0/10] Merge of HSA branch
  - From: Martin Jambor
- [hsa 5/10] OpenMP lowering/expansion changes (gridification)
  - From: Martin Jambor
- Re: [hsa 5/10] OpenMP lowering/expansion changes (gridification)
  - From: Jakub Jelinek
- Splitting up gcc/omp-low.c? (was: [hsa 5/10] OpenMP lowering/expansion changes (gridification))
  - From: Thomas Schwinge
- Re: Splitting up gcc/omp-low.c?
  - From: Bernd Schmidt
- Re: Splitting up gcc/omp-low.c?
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]