This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Matthew Wahab <matthew dot wahab at foss dot arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Dec 2015 10:49:02 +0000
- Subject: Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.
- Authentication-results: sourceware.org; auth=none
- References: <56572B79 dot 9000406 at foss dot arm dot com> <56572D23 dot 4050503 at foss dot arm dot com> <56572ED9 dot 2080108 at foss dot arm dot com> <CAKdteOa3g8fjdmT0viFiR4997YyGWitDe_aoT+i6mObVLZcviQ at mail dot gmail dot com> <56588ECC dot 8070009 at foss dot arm dot com> <5665AF84 dot 5060608 at foss dot arm dot com>
On Mon, Dec 7, 2015 at 4:10 PM, Matthew Wahab
<matthew.wahab@foss.arm.com> wrote:
> On 27/11/15 17:11, Matthew Wahab wrote:
>>
>> On 27/11/15 13:44, Christophe Lyon wrote:
>>>>
>>>> On 26/11/15 16:02, Matthew Wahab wrote:
>>
>>
>>>>> This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM
>>>>> tests to specify targest and to set up command line options.
>>>>> It builds on the ARMv8.1 target support added for AArch64 tests, partly
>>>>> reworking that support to take into account the different
>>>>> configurations
>>>>> that tests may be run under.
>>
>>
>>> I may be mistaken, but -mfpu=neon-fp-armv8 and -mfloat-abi=softfp are not
>>> supported by aarch64-gcc. So it seems to me that
>>> check_effective_target_arm_v8_1a_neon_ok_nocache will not always work
>>> for aarch64 after your patch.
>>
>>
>>> Or does it work because no option is needed and thus "" always
>>> matches and thus the loop always exits after the first iteration
>>> on aarch64?
>>
>>
>> Yes, the idea is that the empty string will make the function first try
>> '-march=armv8.1-a' without any other flag. That will work for AArch64
>> because it
>> doesn't need any other option.
>>
>>> Maybe a more accurate comment would help remembering that, in case
>>> -mfpu option becomes necessary for aarch64.
>>>
>>
>> Agreed, it's worth having a comment to explain what the 'foreach'
>> construct is doing.
>>
>> Matthew
>
>
> I've added a comment to the foreach construct, to make it clearer what
> it's doing.
>
> Matthew
>
> testsuite/
> 2015-12-07 Matthew Wahab <matthew.wahab@arm.com>
>
>
> * lib/target-supports.exp (add_options_for_arm_v8_1a_neon): Update
> comment. Use check_effetive_target_arm_v8_1a_neon_ok to select
> the command line options.
> (check_effective_target_arm_v8_1a_neon_ok_nocache): Update initial
> test to allow ARM targets. Select and record a working set of
> command line options.
> (check_effective_target_arm_v8_1a_neon_hw): Add tests for ARM
> targets.
>
># Return 1 if the target supports the ARMv8.1 Adv.SIMD extension, 0
>-# otherwise. The test is valid for AArch64.
>+# otherwise. The test is valid for AArch64 and ARM. Record the command
>+# line options that needed.
s/that//
Can you also make sure doc/sourcebuild.texi is updated for this helper
function ? If not documented,it would be good to add the documentation
for the same while you are here.
Ramana