This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix new sancov tests
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Dmitry Vyukov <dvyukov at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan at acm dot org>
- Date: Mon, 7 Dec 2015 15:09:07 +0100
- Subject: Re: [PATCH] Fix new sancov tests
- Authentication-results: sourceware.org; auth=none
- References: <CACT4Y+Yy3XXMQ=_CrjCiXmV0q4CQByjWT01FU66Z+CF9niT1YQ at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Dec 06, 2015 at 09:56:32AM +0100, Dmitry Vyukov wrote:
> --- gcc.dg/sancov/sancov.exp (revision 231328)
> +++ gcc.dg/sancov/sancov.exp (working copy)
> @@ -18,6 +18,7 @@
>
> load_lib gcc-dg.exp
> load_lib torture-options.exp
> +load_lib asan-dg.exp
>
> dg-init
> torture-init
> @@ -31,7 +32,11 @@
> { -O2 -g } \
> { -O3 -g } ]
>
> -gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] "" ""
> +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/basic*.c]] "" ""
>
> +if [check_effective_target_fsanitize_address] {
> + gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/asan*.c]] "" ""
> +}
> +
I don't like this, it is bad enough vect.exp works this way, let's not add
further tests depending on test names.
So, either just load_lib asan-dg.exp and change
/* { dg-do compile } */
to
/* { dg-do compile { target fsanitize_address } } */
or avoid the load_lib and add check_effective_target_fsanitize_address
variant that checks compilation with -fsanitize=address of trivial program
instead of linking, put it into lib/target-supports.exp and use it
in dg-do ompile.
Jakub