This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: c-common PATCHes to fully fold warning function arguments
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 2 Dec 2015 18:20:22 +0000
- Subject: Re: RFC: c-common PATCHes to fully fold warning function arguments
- Authentication-results: sourceware.org; auth=none
- References: <565F2E1C dot 4060805 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1512021750100 dot 25367 at digraph dot polyomino dot org dot uk> <565F3434 dot 4030903 at redhat dot com>
On Wed, 2 Dec 2015, Jason Merrill wrote:
> > The new file needs copyright and license notices.
>
> So it does, thanks.
>
> > > The second patch defines fold_for_warn to call c_fully_fold and uses it in
> > > places in the warn_* functions that want to know if the operand has a
> > > constant
> > > value.
> > >
> > > Joseph, are these changes OK for C? The extra folding isn't currently
> > > necessary for C, should fold_for_warn check c_dialect_cxx()?
> >
> > I think it should check that, yes.
>
> Done.
>
> Are these OK?
These are OK for C, with the copyright dates on the new file copied from
c-common.c rather than only 2015.
--
Joseph S. Myers
joseph@codesourcery.com