This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR68067
- From: Alan Lawrence <alan dot lawrence at arm dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Nov 2015 15:07:59 +0000
- Subject: Re: [PATCH] Fix PR68067
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1510271340060 dot 28064 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1510271526510 dot 28064 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1510281437450 dot 28064 at zhemvz dot fhfr dot qr> <563C817D dot 1060107 at arm dot com> <alpine dot LSU dot 2 dot 11 dot 1511061136580 dot 10078 at zhemvz dot fhfr dot qr> <CAOckXuMnh77Y2unSToB=wiY5vfMBMueaZ4SyG4Yj=RBrfeK0dA at mail dot gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1511231042100 dot 4884 at t29 dot fhfr dot qr>
On 23/11/15 09:43, Richard Biener wrote:
On Fri, 20 Nov 2015, Alan Lawrence wrote:
...the asserts
you suggested in (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D68117#c27)...
>>
So I have to ask, how sure are you that those assertions are(/should
be!) "correct"? :)
Ideally they should be correct but they happen to be not (and I think
the intent was that this should be harmless). Basically I tried
to assert that nobody creates stale edge redirect data that is not
later consumed or cleared. Happens to be too optimistic :/
Maybe so, but it looks like the edge_var_redirect_map is still suspect here. On
the ~~28th call to loop_version, from tree_unswitch_loop, the call to
lv_flush_pending_stmts executes (tree-cfg.c flush_pending_stmts):
def = redirect_edge_var_map_def (vm);
add_phi_arg (phi, def, e, redirect_edge_var_map_location(vm));
and BLOCK_LOCATION (redirect_edge_var_map_location(vm)) is
<<invalid tree code> 0x7fb7704a80 side-effects addressable asm_written used
protected static visited tree_0 tree_2 tree_5>
so yeah, next question, how'd that get there...
A.