This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error
- From: Richard Earnshaw <Richard dot Earnshaw at foss dot arm dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Mon, 23 Nov 2015 14:59:05 +0000
- Subject: Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error
- Authentication-results: sourceware.org; auth=none
- References: <563CAC08 dot 7050109 at arm dot com>
On 06/11/15 13:32, Szabolcs Nagy wrote:
> libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error
> message if the 64bit cmpxchg method is not available in the kernel.
>
> __write is not part of the public libc abi, so use write instead.
> (user code may define write in iso c conforming mode and then the
> error message may not be visible before the crash.)
>
> The return type in the declaration of write is fixed too.
>
> OK for trunk and backporting?
>
> libgcc/ChangeLog:
>
> 2015-11-06 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> PR target/68059
> * config/arm/linux-atomic-64bit.c (__write): Rename to...
> (write): ...this and fix the return type.
>
OK.
R.