This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] PR target/68363 Check that argument is real INSN in aarch64_madd_needs_nop
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Mon, 23 Nov 2015 14:51:44 +0000
- Subject: Re: [PATCH][AArch64] PR target/68363 Check that argument is real INSN in aarch64_madd_needs_nop
- Authentication-results: sourceware.org; auth=none
- References: <5649D86C dot 4010409 at arm dot com>
On Mon, Nov 16, 2015 at 01:21:48PM +0000, Kyrill Tkachov wrote:
> Hi all,
>
> This RTL checking ICE occurs when processing an rtx_insn* in
> aarch64_madd_needs_nop that apparently holds JUMP_TABLE_DATA. This shouldn't
> be passed to recog. So instead reject it with the INSN_P check. Such
> rtx_insns are not relevant to the code in aarch64_madd_needs_nop anyway.
>
> Bootstrapped and tested on trunk, GCC 5 and 4.9 configured with
> --enable-fix-cortex-a53-835769 --enable-checking=yes,rtl.
>
> Ok for all branches? (the testcase passes on 4.8, presumably before the
> conversion to rtx_insn)
>
> 2015-11-16 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> PR target/68363
> * config/aarch64/aarch64.c (aarch64_madd_needs_nop): Reject arguments
> that are not INSN_P.
>
> 2015-11-16 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> PR target/68363
> * gcc.target/aarch64/pr68363_1.c: New test.
OK.
Thanks,
James