Re: [PATCH] Allow embedded timestamps by C/C++ macros to be set externally (2)

[Dhole <dhole at openmailbox dot org>]

On 11/17/2015 12:26 AM, Joseph Myers wrote:
> fprintf to stderr is never appropriate.  All diagnostics should go through 
> a diagnostic function that properly causes the message to be translated.
> 
> If you want a fatal error (exit immediately after giving the message 
> rather than continuing compilation), use the fatal_error function, which 
> takes an explicit location.  You can use UNKNOWN_LOCATION to avoid an 
> input file being named, (...)

Thanks for the advise! I've applied the change in the patch.

> Also, this environment variable needs documenting in cppenv.texi.

I have added the documentation as required, it's included in the
attached patch.

Regarding the copyright assignment process, it's in progress :)


Best regards,
Dhole

Attachment: ChangeLog
Description: Text document

Attachment: gcc-SOURCE_DATE_EPOCH-patch-2015_11_18.diff.txt
Description: Text document