This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 00/16] Unit tests framework (v3)
- From: Mike Stump <mikestump at comcast dot net>
- To: Jeff Law <law at redhat dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, Bernd Schmidt <bschmidt at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 16 Nov 2015 17:53:12 -0800
- Subject: Re: [PATCH 00/16] Unit tests framework (v3)
- Authentication-results: sourceware.org; auth=none
- References: <5589B2FB dot 8010500 at redhat dot com> <1445975355-37660-1-git-send-email-dmalcolm at redhat dot com> <5630B3C9 dot 10409 at redhat dot com> <563271AF dot 1000500 at redhat dot com> <56334C5D dot 1070000 at redhat dot com> <56339342 dot 4000101 at redhat dot com> <564A1DAB dot 1030700 at redhat dot com> <1447699711 dot 19594 dot 50 dot camel at surprise> <564A62D0 dot 6010908 at redhat dot com>
On Nov 16, 2015, at 3:12 PM, Jeff Law <law@redhat.com> wrote:
> So I'd tend to want them either at the end of the file with a single #if CHECKING_P or as a separate foo-tests file.
Hum… I kinda don’t want the main files mucked up with tests. I think I’d rather have
#if CHECKING_P
#include "test/expr-test.h"
#endif
at the end, and punt the whole lot into a single subdirectory that most people, most of the time, can simply ignore. Wading through a ton of code that you aren’t interested in, is, well, annoying. We so rarely change apis that I don’t see the harm in the separation. Since we default to testing, and since the test suite will horrifically fail (if it works) if people do it wrong, I don’t think people will forget to update the test suite as the apis change.
> I'm leaning towards suggesting we get on a branch and look to merge it into the next stage1. This isn't something that's going to have a user impact.
Depends on the patch set, but, I’d like to think most would be fairly safe to put in post stage 1.