This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [ARM] neon-testgen.ml typo
- From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>, Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>, Jim Wilson <jim dot wilson at linaro dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 13 Nov 2015 11:24:41 +0000
- Subject: Re: [PATCH] [ARM] neon-testgen.ml typo
- Authentication-results: sourceware.org; auth=none
- References: <CABXYE2W0SoGRC1HzjEMdXkOBz7LGLvqUFU_tzkED8aOv=X4THw at mail dot gmail dot com> <56337FD6 dot 5040602 at foss dot arm dot com> <CAKdteOYbxkfwHHbuBC+sH_STGMKoipH7m3LFD9jM44D4Fn6Bfw at mail dot gmail dot com> <CAJA7tRY6dxhbKEURRLmY+Q_HO-tUJMkrNYXCdm4PMGamvnCc1w at mail dot gmail dot com> <CAKdteOYEGnXKOLRZy=SD-qaqw=FH8KfUACrNEjB2daVZQAE_JA at mail dot gmail dot com> <CAKdteOaiKE6vTc=K5mxkZNHkMkjP-Cm2sDg2o6YWQQaLZy4ZzQ at mail dot gmail dot com> <CAKdteOaja1daNmJ6ayTetgR50g491KFUOoZUX-zTKqCR-vFGCw at mail dot gmail dot com> <CAJA7tRaWciEYPcBwwqtj11137Xxr0gdjN7LzwrgFbxcvyNJY7Q at mail dot gmail dot com>
On 13/11/15 11:18, Ramana Radhakrishnan wrote:
Hmm. I hadn't noticed that the crypto intrinsics tests where generated by
neon-testgen.ml, I thought they were hand-written.
The tests I added do not cover the crypto intrinsics, so I'm going
to revert r230274 and restore all the tests generated by neon-testgen.ml
until we have better coverage in advsimd-intrinsics.
From what I remember from a few days back I thought it was generally
ok to get rid of the lot as we had test coverage for everything else
in gcc.target/arm .
Thus don't bother reverting.
+1. I'll also add that you can now remove neon.ml from config/arm.
And also, I think we can move the remaining hand-written tests from gcc.target/arm/neon/
into gcc.target/arm/ and remove the neon/ directory altogether.
Kyrill
Ramana
Sorry for the oversight.
Christophe.
Christophe.
regards
Ramana
Christophe.
regards
Ramana