This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] PR target/67929 Tighten vfp3_const_double_for_bits checks
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>, Yvan Roux <yvan dot roux at linaro dot org>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Mon, 2 Nov 2015 09:24:45 +0000
- Subject: Re: [PATCH][ARM] PR target/67929 Tighten vfp3_const_double_for_bits checks
- Authentication-results: sourceware.org; auth=none
- References: <561E4941 dot 6030204 at arm dot com> <CAJA7tRb86KziwJrB9tB-=7b5h6kY=AnHJFa3GAR_hA4sCP7dRw at mail dot gmail dot com> <CAD57uCc19EnKh7uamjimE5RsdyeK5hVgAD=a9vpTm5Og6b=_3A at mail dot gmail dot com> <563720F1 dot 3070903 at foss dot arm dot com> <CAD57uCeAow38sjwN6ztaND0TTrKf-fe-WfYJgbwhnAi_LNybDA at mail dot gmail dot com> <CAKdteOYCAQMqO1e2GaXTTxS52iH4_Wu4BWzvr63YsqOQtrin8g at mail dot gmail dot com>
On 02/11/15 09:01, Christophe Lyon wrote:
> On 2 November 2015 at 09:51, Yvan Roux <yvan.roux@linaro.org> wrote:
>> On 2 November 2015 at 09:38, Ramana Radhakrishnan
>> <ramana.radhakrishnan@foss.arm.com> wrote:
>>>
>>>>>>
>>>>>> 2015-10-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>>>>>
>>>>>> PR target/67929
>>>>>> * gcc.target/arm/pr67929_1.c: New test.
>>>>
>>>> This test fails when tested on hard-float targets, adding the
>>>> following line to avoid testing it in such cases will fix the issue,
>>>> but I wonder if there is a better dejaGNU directives sequence to do
>>>> that.
>>>>
>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } {
>>>> "*" } { "" } } */
>>>
>>> No, not without further investigation into why the test is failing.
>>
>> Sorry, it fails because of the ABI mismatch between the built libs for
>> HF targets and the testcase which is built with the flag
>> -mfloat-abi=softfp (which is added by the directive arm_vfpv3_ok)
>>
> I think that's what I meant in:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67929#c7
Ah, I see what you mean - instead I would just remove all the special options and move this test into gcc.c-torture/execute.
There are enough testers that test by default to armhf now for us to be worried about testing the exact combination.
regards
Ramana
>
> Christophe.
>
>> Yvan
>>
>>> regards
>>> Ramana
>>>
>>>>
>>>> Cheers,
>>>> Yvan
>>>>