This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Fri, 30 Oct 2015 14:37:39 +0000
- Subject: Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost
- Authentication-results: sourceware.org; auth=none
- References: <5632430F dot 7080402 at arm dot com>
On 29/10/15 16:02, Kyrill Tkachov wrote:
> Hi all,
>
> An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails because
> cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL.
> The correct thing to do is to call single_set on dep, which will return a simple SET
> that we can take the SET_DEST of or NULL if there's more than one SET.
>
> This patch does that.
> The arm-none-eabi build passes.
> Bootstrapped and tested on arm-none-linux-gnueabihf.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2015-10-29 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * config/arm/arm.c (cortex_a9_sched_adjust_cost): Use reg_set_p to
> check for dependencies.
Ok - but I think we also need a patch to improve the comment for reg_set_p, probably because it started life as internal function but now has wider visibility.
Thanks,
Ramana