This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Richard Biener <richard dot guenther at gmail dot com>
Cc: tbsaunde+gcc at tbsaunde dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 30 Oct 2015 13:28:08 +0100
Subject: Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c
Authentication-results: sourceware.org; auth=none
References: <1446205692-22412-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <1446205692-22412-6-git-send-email-tbsaunde+gcc at tbsaunde dot org> <56335D46 dot 9070409 at redhat dot com> <CAFiYyc3DdUjfgF3O3-Q-WCN=Xanny9aSwHxe6Aha_wQUTZH9Hg at mail dot gmail dot com>


it's not target independent code.  Are you suggesting to add a config/
to libobjc?  IMHO for a not really mantained frontend / target lib that's
an excessive requirement.


If necessary, then yes that would be a better solution.

Even just keeping the abstraction of the macro and putting definitionsof it inside #ifdef at the top of the file would be an improvement overthe submitted patch, but IMO still not really compatible with our standards.



Bernd

Follow-Ups:
- Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c
  - From: Richard Biener

References:
- [PATCH 0/5] remove tm.h from encoding.c
  - From: tbsaunde+gcc
- [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c
  - From: tbsaunde+gcc
- Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c
  - From: Bernd Schmidt
- Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]