This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 04/10] Reimplement diagnostic_show_locus, introducing rich_location classes (v5)
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 29 Oct 2015 22:19:59 -0600
- Subject: Re: [PATCH 04/10] Reimplement diagnostic_show_locus, introducing rich_location classes (v5)
- Authentication-results: sourceware.org; auth=none
- References: <56300286 dot 4040103 at redhat dot com> <1446055764-23753-1-git-send-email-dmalcolm at redhat dot com>
On 10/28/2015 12:09 PM, David Malcolm wrote:
If you have a blob of new code and a blob of deletes, even breaking it
down that way may help in this case (ie, a patch with new classes &
code, then a pass that deletes old crud we're not going to use anymore).
I've split patch 4 of the kit into 3 sub-patches:
[PATCH 4a] diagnostic-show-locus.c changes: Deletions
[PATCH 4b] diagnostic-show-locus.c changes: Insertions
[PATCH 4c] Other changes: everything apart from diagnostic-show-locus.c changes
4a, 4b, and 4c should appear as followups to this mail (assuming my
"git send-email" command works OK). They're only split up for
ease-of-review purposes; they're intended to be committed as one commit.
Right, the split is just to make the diffs readable. They'll be an
atomic commit. We're on the same page here.
The 4a/4b split seems to have allowed "git diff" to done a
much better job on diagnostic-show-locus.c.
Most definitely :-)
Patch 4c contains updates based on your review comments below; a diff
relative to the prior version of the patch can be seen at:
https://dmalcolm.fedorapeople.org/gcc/2015-10-28/rich-locations/0001-Fix-issues-found-in-review.patch
4a, 4c are OK. I'm working through 4b now.
Thanks.
jeff