This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Bernd Schmidt <bschmidt at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, Jiong Wang <jiong dot wang at foss dot arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 29 Oct 2015 09:25:54 +0000
- Subject: Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOrNKmQpsfXuvNOyevnpJq_muNmJCdvOYYKy6weEeFFi=Q at mail dot gmail dot com> <562F5E11 dot 1090503 at redhat dot com> <CAMe9rOqVM9Qhq1qPjo0qAVQFCWw-c+Ne2CtkpX_TcW5fcVbBuA at mail dot gmail dot com> <562F739F dot 2090000 at foss dot arm dot com> <CAMe9rOrL89kK=qxPS7n4e28+-3cpv_EdG0E0YT5uf3ppYNFamw at mail dot gmail dot com> <562F818A dot 90003 at foss dot arm dot com> <562F8B6F dot 7060605 at foss dot arm dot com> <CAMe9rOrOkzkY13Jja9VqNx536jqZZcuVYYaxOt6XcZGcP1gR+w at mail dot gmail dot com> <562F9B4C dot 8000607 at foss dot arm dot com> <562FB812 dot 7050601 at redhat dot com> <CAMe9rOr2f4TQA3LV5fdwiVOkokEe3s+DV-=NeMnRJ9jv-LrgCQ at mail dot gmail dot com> <563166EC dot 8050903 at redhat dot com> <CAMe9rOpcPHqyjKr-8UWCZLjbhwqosm1B=D5J2P7qxpgAgoqSyg at mail dot gmail dot com> <56317236 dot 80602 at redhat dot com> <CAMe9rOoi7XHhQD3iT4gyKjy1FtaJ8Etu59c6Z+u79O7pz0Efsw at mail dot gmail dot com> <56317493 dot 8010400 at redhat dot com> <CAMe9rOoNiUNxQ9KgFKtwYxJF+KLNsqZP+gGh7YHkviCxMiHy8g at mail dot gmail dot com>
On 29/10/15 01:47, H.J. Lu wrote:
> On Wed, Oct 28, 2015 at 6:21 PM, Bernd Schmidt <bschmidt@redhat.com> wrote:
>> On 10/29/2015 02:14 AM, H.J. Lu wrote:
>>>
>>> On Wed, Oct 28, 2015 at 6:11 PM, Bernd Schmidt <bschmidt@redhat.com>
>>> wrote:
>>>>
>>>> On 10/29/2015 02:10 AM, H.J. Lu wrote:
>>>>>
>>>>>
>>>>> On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law <law@redhat.com> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> So I'll ask again, why did you commit a patch which you clearly knew
>>>>>> did
>>>>>> not
>>>>>> meet the conditions Bernd set forth for approval?
>>>>>
>>>>>
>>>>>
>>>>> I believed that aarch64 backend didn't properly handle -fno-plt,
>>>>> which shouldn't block my patch.
>>
>>
>> Actually this is even worse than I thought because it sounds like you're
>> saying you knowingly checked something in while being aware it would break
>> another port.
>>
>
> Only when -fno-plt was used.
So, that's a target independent feature in GCC ! So, I don't see how that
justifies the commit.
>>
>> Sometimes It seems that it is the only way to get attention from the
>> community. BTW, my patch was submitted in August.
>>
I personally do *not* understand how that is an excuse.
regards
Ramana