This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Bernd Schmidt <bschmidt at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, Jiong Wang <jiong dot wang at arm dot com>
- Date: Tue, 27 Oct 2015 13:50:20 +0100
- Subject: Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOrNKmQpsfXuvNOyevnpJq_muNmJCdvOYYKy6weEeFFi=Q at mail dot gmail dot com> <562F5E11 dot 1090503 at redhat dot com> <CAMe9rOqVM9Qhq1qPjo0qAVQFCWw-c+Ne2CtkpX_TcW5fcVbBuA at mail dot gmail dot com>
On Tue, Oct 27, 2015 at 12:37 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Oct 27, 2015 at 4:20 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:
>> On 10/19/2015 09:55 PM, H.J. Lu wrote:
>>>
>>> * calls.c (prepare_call_address): Don't handle -fno-plt here.
>>
>>
>> Is any other target using -fno-plt? If not, and if that's really just a
>
> aarch64 is the only target which checks -fno-plt from commit log below.
> I CCed the code author. aarch64 may suffer from the same issue.
>
>> revert I'll approve it on the condition that the x86 maintainers are happy
>> with the rest of the changes.
>
> Uros, can you take a look?
I can only say that I don't oppose the changes. The details of linking
are out of my expertise, but OTOH, you probably know these details
better than I.
So, I'll rubberstamp the patch with OK, assuming you will fix eventual fallout.
Thanks,
Uros.