This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL


On 10/21/2015 09:00 PM, Doug Evans wrote:
I happened to notice local prefixes not working with musl.
Fixes thusly.

Index: config/linux.h
===================================================================
--- config/linux.h    (revision 229130)
+++ config/linux.h    (working copy)
@@ -174,6 +174,7 @@
  #define INCLUDE_DEFAULTS                \
    {                            \
      INCLUDE_DEFAULTS_MUSL_GPP                \
+    INCLUDE_DEFAULTS_MUSL_LOCAL                \
      INCLUDE_DEFAULTS_MUSL_PREFIX            \
      INCLUDE_DEFAULTS_MUSL_CROSS                \
      INCLUDE_DEFAULTS_MUSL_TOOL                \

Looks pretty obvious given that the macro isn't otherwise used AFAICT. However, I have no idea whether the order is right, since the purpose of all this code here is apparently only to provide a different order than the default.

So, someone who worked on the original musl patches should comment. I would also like to know precisely which ordering change over the default is required, and that it be documented. Ideally we'd come up with a solution that makes us not duplicate all this stuff in linux.h.


Bernd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]