This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/3] Header file reduction - backend files.


On 10/22/2015 06:25 PM, Jeff Law wrote:
On 10/01/2015 08:33 PM, Andrew MacLeod wrote:
these are all in the main gcc directory. 297 files total.

Everything bootstraps on x86_64-pc-linux-gnu and
powerpc64le-unknown-linux-gnu.  All targets in config-list.mk still
build. Regressions tests also came up clean.

OK for trunk?
So just to be clear, I'm looking at the backend-reorder patch. Now that I know it's going to be reordering & removing duplicates, I know better what to expect.

Can you please look at data-streamer-{in,out}.c, data-streamer.c, gimplify-me.c. Maybe its changed recently, but options.h is removed as a duplicate by your patch, but on the trunk, I only see it showing up once (using your tools)

show-headers data-streamer.c  -soptions.h
on trunk shows me:
  alias.h
  backend.h
    tm.h
      options.h  (1)               <<-------
        flag-types.h
        i386-opts.h
<...>
  hard-reg-set.h
  options.h  (2)                <<-------
  fold-const.h

so the first occurrence is loaded via tm.h from backend.h




I realize it's gotten a little stale, but IMHO once approved, if you need to make adjustments due to changes since you originally produced the patch those adjustments are pre-approved.

yeah. what I've been doing is apply the patch... and anything that fails to apply, simply run the tool again on that file... its easier than trying to fix things up :-)

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]