On 10/12/2015 11:57 PM, Jeff Law wrote:
>On 10/06/2015 06:40 AM, Bernd Schmidt wrote:
>>I'm not entirely sure what to make of this series. There seem to be good
>>bits in there but also some things I find questionable. I'll add some
>>comments on things that occur to me.
>Maybe we should start pulling out the bits that we think are ready & good and
>start installing them independently.
>
(snip)
>>Probably a good thing, but it looks like libcpp has grown its own
>>variant linemap_assert; we should check whether that can be replaced.
>>
>>Also, the previous patch already introduces a use of gcc_assert, or at
>>least a reference to it, and it's only defined here. The two
>>modifications of libcpp/system.h should probably be merged into one.
>Agreed.
>
>jeff
I moved the 'libcpp/system.h' parts into the first patch of the series. As for
replacing linemap_assert, I hope it can be done separately.