This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch AArch64 63304] Fix issue with global state.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, jiong dot wang at arm dot com
- Date: Tue, 20 Oct 2015 14:52:08 +0100
- Subject: Re: [Patch AArch64 63304] Fix issue with global state.
- Authentication-results: sourceware.org; auth=none
- References: <20151016110524 dot GA23104 at e105545-lin>
On 16 October 2015 at 12:05, Ramana Radhakrishnan
<ramana.radhakrishnan@arm.com> wrote:
> 2015-10-15 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> PR target/63304
> * config/aarch64/aarch64.c (aarch64_nopcrelative_literal_loads): New.
> (aarch64_expand_mov_immediate): Use aarch64_nopcrelative_literal_loads.
> (aarch64_classify_address): Likewise.
> (aarch64_secondary_reload): Likewise.
> (aarch64_override_options_after_change_1): Adjust.
> * config/aarch64/aarch64.md (aarch64_reload_movcp<GPF_TF:mode><P:mode>):
> Use aarch64_nopcrelative_literal_loads.
> (aarch64_reload_movcp<VALL:mode><P:mode>): Likewise.
> * config/aarch64/aarch64-protos.h (aarch64_nopcrelative_literal_loads): Declare
>
> 2015-10-15 Jiong Wang <jiong.wang@arm.com>
> Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> PR target/63304
> * gcc.target/aarch64/pr63304-1.c: New test.
> +/* Global flag for PC relative loads. */
> +bool aarch64_nopcrelative_literal_loads;
Yuk... but I don't have a better suggestion to hand.
> +++ b/gcc/testsuite/gcc.target/aarch64/pr63304-1.c
In that directory I've been pestering folks to follow the name
convention on the wiki for new additions, so _1 please (or change the
wiki ;-).
Otherwise OK with me.
Cheers
/Marcus