This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix pr67963
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Yulia Koval <vaalfreja at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Wed, 14 Oct 2015 08:17:47 -0700
- Subject: Re: [PATCH] Fix pr67963
- Authentication-results: sourceware.org; auth=none
- References: <CAE0nxxhacnNEGpHmZn5tFLGWZ9AJ+iBFwVBAmUJ+8EHxvpGn+w at mail dot gmail dot com> <CAMe9rOrZPBbsofdN3TwR_V92v=kc8U5oyk-sD=K4BR1s_hjWuA at mail dot gmail dot com>
On Wed, Oct 14, 2015 at 8:15 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Oct 14, 2015 at 8:08 AM, Yulia Koval <vaalfreja@gmail.com> wrote:
>> Hi,
>>
>> This patch fixes the issue:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963
>>
>> gcc/config/i386/i386.c (ix86_option_override_internal) Disable
>> 80387 mask if lakemont target is set.
>>
>> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>> index 4c25c9e..db722aa 100644
>> --- a/gcc/config/i386/i386.c
>> +++ b/gcc/config/i386/i386.c
>> @@ -4943,6 +4943,12 @@ ix86_option_override_internal (bool main_args_p,
>> break;
>> }
>>
>> + if (!strcmp (opts->x_ix86_arch_string, "lakemont"))
>> + {
>> + opts->x_target_flags &= ~MASK_80387;
>> + opts_set->x_target_flags |= MASK_80387;
>> + }
>> +
>> if (TARGET_X32 && (opts->x_ix86_isa_flags & OPTION_MASK_ISA_MPX))
>> error ("Intel MPX does not support x32");
>>
>> Ok for trunk?
>
> We should add a bit to "struct pta" to indicate availability of
> 80387 ISA and turn it off for lakemount if 90387 ISA hasn't be
> turned on explicitly.
Something like
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index a2314e7..1cea58e 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -4348,6 +4348,7 @@ ix86_option_override_internal (bool main_args_p,
const enum processor_type processor;
const enum attr_cpu schedule;
const unsigned HOST_WIDE_INT flags;
+ const unsigned HOST_WIDE_INT mask;
}
const processor_alias_table[] =
{
> We also need some testcases.
>
> --
> H.J.
--
H.J.