This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH PR67909 PR67947]
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Yuri Rumyantsev <ysrumyan at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Igor Zamyatin <izamyatin at gmail dot com>
- Date: Tue, 13 Oct 2015 14:53:44 +0200
- Subject: Re: [PATCH PR67909 PR67947]
- Authentication-results: sourceware.org; auth=none
- References: <CAEoMCqR-LXyr8xbbH6=CT0rJNSmpKTG+za257RO6Gc13RWcHyg at mail dot gmail dot com> <CAMe9rOoH=_0h6FokqeDoCPb2zL_uVGuM2sUX6nyWQCJ=_HhObQ at mail dot gmail dot com> <CAEoMCqTTRPXkoBBfONnA-GQEiqzZttQ9EOEc1y=2b0WjsJPhVg at mail dot gmail dot com>
On Tue, Oct 13, 2015 at 2:49 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
> Here is updated patch with splitting long line.
> The patch is attached.
Ok with aligning the guard_edge == ... line properly
Thanks,
Richard.
> Yuri.
>
> 2015-10-13 15:38 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>> On Tue, Oct 13, 2015 at 4:57 AM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
>>> Hi All,
>>>
>>> Here is a simple patch for unswitching outer loop through guard-edge
>>> hoisting. The check that guard-edge is around the inner loop was
>>> missed.
>>>
>>> Bootstrapping and regression testing did not show new failures.
>>>
>>> Is it OK for trunk?
>>>
>>> ChangeLog:
>>> 2014-10-13 Yuri Rumyantsev <ysrumyan@gmail.com>
>>>
>>> PR tree-optimization/67909, 67947
>>> * tree-ssa-loop-unswitch.c (find_loop_guard): Add check that GUARD_EDGE
>>> really skip the inner loop.
>>>
>>> gcc/testsuite/ChangeLog
>>> * gcc.dg/torture/pr67947.c: New test.
>>
>> + /* Guard edge must skip inner loop. */
>> + if (!dominated_by_p (CDI_DOMINATORS, loop->inner->header,
>> + guard_edge == fe ? te->dest : fe->dest))
>> ^^^^ It should line up with "CDI_DOMINATORS".
>>
>> + fprintf (dump_file, "Guard edge %d --> %d is not around the
>> loop!\n",guard_edge->src->index,guard_edge->dest->index);
>>
>> Please break lone line.
>>
>> --
>> H.J.