This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gomp4] remove bogus tests


I've committed this to gomp4 branch. Both these tests are trying an 'acc loop' outside of an offload region. That's an error.

Of course, a diagnostic should be emitted, but the remainder of the tests are apparently checking valid constructs. So I chose to simply remove the erroneous case for the moment.

If anyone's wondering, a patch I'm working on blew up on these two cases because it tried to manipulate the loop and then discovered it wasn't in an offloaded function.

nathan
2015-10-10  Nathan Sidwell  <nathan@codesourcery.com>

	* c-c++-common/goacc-gomp/nesting-1.c: Remove bogus loop case.
	* c-c++-common/goacc/nesting-1.c: Likewise.

Index: gcc/testsuite/c-c++-common/goacc-gomp/nesting-1.c
===================================================================
--- gcc/testsuite/c-c++-common/goacc-gomp/nesting-1.c	(revision 228669)
+++ gcc/testsuite/c-c++-common/goacc-gomp/nesting-1.c	(working copy)
@@ -44,16 +44,3 @@ f_acc_parallel (void)
     i = 0;
   }
 }
-
-void
-f_omp_parallel (void)
-{
-#pragma omp parallel
-  {
-    int i;
-
-#pragma acc loop
-    for (i = 0; i < 2; ++i)
-      ;
-  }
-}
Index: gcc/testsuite/c-c++-common/goacc/nesting-1.c
===================================================================
--- gcc/testsuite/c-c++-common/goacc/nesting-1.c	(revision 228669)
+++ gcc/testsuite/c-c++-common/goacc/nesting-1.c	(working copy)
@@ -92,10 +92,6 @@ f_acc_data (void)
 #pragma acc enter data copyin(i)
 
 #pragma acc exit data delete(i)
-
-#pragma acc loop
-      for (i = 0; i < 2; ++i)
-	;
     }
   }
 }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]