This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

From: "Lynn A. Boger" <laboger at linux dot vnet dot ibm dot com>
To: Matthias Klose <doko at ubuntu dot com>, Ian Lance Taylor <iant at golang dot org>
Cc: David Edelsohn <dje dot gcc at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Alan Modra <amodra at gmail dot com>
Date: Thu, 8 Oct 2015 13:56:35 -0500
Subject: Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack
Authentication-results: sourceware.org; auth=none
References: <55D39752 dot 5090602 at linux dot vnet dot ibm dot com> <55D4DA0B dot 6000106 at ubuntu dot com> <55D50BBA dot 6060909 at linux dot vnet dot ibm dot com> <55DF7A72 dot 2040208 at linux dot vnet dot ibm dot com> <CAGWvnym=hEBrUUtp=ZmGNex_N92rA-ME93pXVtG638UYATNFrw at mail dot gmail dot com> <55F86277 dot 8010100 at linux dot vnet dot ibm dot com> <CAKOQZ8zQWx4oiok0FHDxOm7pX0StLJvhS5d=8YG4NM4Zrb8PDA at mail dot gmail dot com> <55FB10E7 dot 9090607 at linux dot vnet dot ibm dot com> <CAOyqgcVA_zhivM0+qRFk9bDT42Sot-HX95M1NtZjLVphZy_0vg at mail dot gmail dot com> <56101F0E dot 8000003 at ubuntu dot com> <56153C00 dot 2000209 at linux dot vnet dot ibm dot com> <561556F9 dot 8030802 at ubuntu dot com>

I think my original fix with linux.h doing the #undef onTARGET_CAN_SPLIT_STACK_64BIT is the right fix at least

for powerpc-linux-gnu 32 bit only.

It works for powerpc-linux-gnu without multilib and doesn't breakpowerpc64-linux-gnu or powerpc64le-linux-gnu.

Can you tell me how you are configuring the multilib build that defaultsto powerpc-linux-gnu and how it

fails?  Maybe there is another problem for that combination.

As David noted, the use of TARGET_64BIT or TARGET_POWERPC64 won't workfor this #define.


On 10/07/2015 12:31 PM, Matthias Klose wrote:

On 07.10.2015 17:36, Lynn A. Boger wrote:

Pretty sure this is the fix, but still doing some testing.

linux.h isn't included for multilib enabled builds defaulting topowerpc-linux-gnu, I am currently testing


--- gcc/config/rs6000/sysv4.h    (revision 228571)
+++ gcc/config/rs6000/sysv4.h    (working copy)
@@ -943,8 +943,9 @@
 /* On ppc64 and ppc64le, split stack is only support for
    64 bit. */
 #undef TARGET_CAN_SPLIT_STACK_64BIT
-#if TARGET_GLIBC_MAJOR > 2 \
-  || (TARGET_GLIBC_MAJOR == 2 && TARGET_GLIBC_MINOR >= 18)
+#if TARGET_64BIT \
+  && (TARGET_GLIBC_MAJOR > 2 \
+      || (TARGET_GLIBC_MAJOR == 2 && TARGET_GLIBC_MINOR >= 18))
 #define TARGET_CAN_SPLIT_STACK_64BIT
 #endif

Follow-Ups:
- Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack
  - From: Matthias Klose

References:
- Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack
  - From: Matthias Klose
- Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack
  - From: Matthias Klose

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]