This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch 0/3] Header file reduction.
- From: Michael Matz <matz at suse dot de>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, Andrew MacLeod <amacleod at redhat dot com>, Bernd Schmidt <bschmidt at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 8 Oct 2015 17:48:43 +0200 (CEST)
- Subject: Re: [patch 0/3] Header file reduction.
- Authentication-results: sourceware.org; auth=none
- References: <560DEA79 dot 8050709 at redhat dot com> <56127AA4 dot 9090707 at redhat dot com> <5612D925 dot 2040806 at redhat dot com> <5614409D dot 8080007 at redhat dot com> <CAFiYyc0KJdghtQoPiRfgY5u4G1R6yeG7QgaKGBqZouhZHb4BsQ at mail dot gmail dot com>
Hi,
On Wed, 7 Oct 2015, Richard Biener wrote:
> > I'm probably the last person in the world that still generally prefers
> > -cp :-) I'm getting to the point where I can tolerate -u.
>
> No, I prefer -cp too - diff just too easily makes a mess out of diffs
> with -u, esp. if you have re-indenting going on as well.
Actually -c was the recommended form of sending patches for many years
even in our own guidelines. It only got changed to -up or -cp when moving
instructions from the texinfo files to the website in 2001. From gcc 3.0
(https://gcc.gnu.org/onlinedocs/gcc-3.0/gcc_10.html):
Use `diff -c' to make your diffs. Diffs without context are hard for us
to install reliably. More than that, they make it hard for us to study
the diffs to decide whether we want to install them. Unidiff format is
better than contextless diffs, but not as easy to read as `-c' format.
If you have GNU diff, use `diff -cp', which shows the name of the
function that each change occurs in.
;-) (IMHO it depends on what the patch does if -c or -u is better, if
the _change_ is important -u might be better, if the new state is the
more interesting thing, -c is)
Ciao,
Michael.