This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/3] Header file reduction - backend files.


On 10/01/2015 08:33 PM, Andrew MacLeod wrote:
these are all in the main gcc directory.  297 files total.

Everything bootstraps on x86_64-pc-linux-gnu and
powerpc64le-unknown-linux-gnu.  All targets in config-list.mk still
build. Regressions tests also came up clean.

OK for trunk?
So as I look at this and make various spot checks, what really stands out is how often something like alias.h gets included, often in places that have absolutely no business/need to be looking at that file. Cut-n-paste at its worst. It happens to many others, but alias.h seems to have gotten its grubby self into just about everywhere for reasons unkonwn.

I find myself also wondering if a two step approach would make this easier. Step #1 being ordering the headers, step #2 being removal of the duplicates. As you note, the downside is two checkins that would affect most files in the tree. I guess I'll keep slogging through the patch as is...

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]