This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix default_binds_local_p_2 for extern protected data
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, Richard Henderson <rth at redhat dot com>
- Date: Wed, 30 Sep 2015 15:47:37 +0200
- Subject: Re: [PATCH] Fix default_binds_local_p_2 for extern protected data
- Authentication-results: sourceware.org; auth=none
- References: <55AFCC7C dot 8010105 at arm dot com> <55C8854D dot 5060609 at arm dot com> <55FA84C1 dot 6010603 at arm dot com>
On 09/17/2015 11:15 AM, Szabolcs Nagy wrote:
ping 2.
this patch is needed for working visibility ("protected")
attribute for extern data on targets using default_binds_local_p_2.
https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01871.html
I hesitate to review this one since I don't think I understand the
issues on the various affected arches well enough. It looks like Jakub
had some input on the earlier changes, maybe he could take a look? Or
maybe rth knows best. Adding Ccs.
It would help to have examples of code generation demonstrating the
problem and how you would solve it. Input from the s390 maintainers
whether this is correct for their port would also be appreciated.
Needs a further binutils patch too to emit R_*_GLOB_DAT
instead of R_*_RELATIVE relocs for protected data.
The glibc elf/tst-protected1a and elf/tst-protected1b
tests depend on this.
What is the consequence of not having this binutils patch? Is the gcc
patch and improvement, a null, or are there situations where it causes
regressions without the binutils patch?
Tested ARM and AArch64 targets.
Tested how, with or without this binutils patch?
Bernd