This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info
- From: Xinliang David Li <davidxl at google dot com>
- To: Rong Xu <xur at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 29 Sep 2015 16:25:48 -0700
- Subject: Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info
- Authentication-results: sourceware.org; auth=none
- References: <CAF1bQ=RSBFreYBNdPdHE2O_GcNhdA=y2f6kVGsJ6d=ZqZRuhjA at mail dot gmail dot com> <CAAkRFZJZPLzLz5XprBz=SyhTVPRiUreCTkvTL0qJ=ENnHAGbjQ at mail dot gmail dot com> <CAF1bQ=SAc_508a_D7bwae_Vw8rqGtJUeUrCpy_s-ukef0oSfqw at mail dot gmail dot com>
ok.
David
On Tue, Sep 29, 2015 at 4:08 PM, Rong Xu <xur@google.com> wrote:
> You are right. I attached the updated patch to this email.
>
> On Tue, Sep 29, 2015 at 3:10 PM, Xinliang David Li <davidxl@google.com> wrote:
>> else
>> {
>> gfi_ptr = gi_ptr->functions[f_ix];
>> - if (gfi_ptr && gfi_ptr->key == gi_ptr)
>> + if (gfi_ptr)
>> length = GCOV_TAG_FUNCTION_LENGTH;
>> - else
>> - length = 0;
>> }
>>
>> The removal of 'else' path seems wrong.
>>
>> David
>>
>>
>> On Tue, Sep 29, 2015 at 1:46 PM, Rong Xu <xur@google.com> wrote:
>>> Hi,
>>>
>>> This patch is for google/gcc-4_9 branch.
>>>
>>> The 'key' field in gcov_fn_info is designed to allow gcov function
>>> data to be COMDATTed, but the comdat elimination never works. This
>>> patch removes this field to reduce the instrumented object size.
>>>
>>> Thanks,
>>>
>>> -Rong