This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 14/15][ARM/AArch64 Testsuite]Add test of vcvt{,_high}_i{f32_f16,f16_f32}
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Alan Lawrence <alan dot lawrence at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, christophe dot lyon at linaro dot org
- Date: Tue, 22 Sep 2015 15:36:21 +0100
- Subject: Re: [PATCH 14/15][ARM/AArch64 Testsuite]Add test of vcvt{,_high}_i{f32_f16,f16_f32}
- Authentication-results: sourceware.org; auth=none
- References: <55B7670B dot 1090902 at arm dot com> <1440511043-7622-1-git-send-email-alan dot lawrence at arm dot com>
On 25 August 2015 at 14:57, Alan Lawrence <alan.lawrence@arm.com> wrote:
> Sorry - wrong version posted. The hunk for add_options_for_arm_neon_fp16 has
> moved to the previous patch! This version also fixes some whitespace issues.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/advsimd-intrinsics/vcvt_f16.c: New.
> * lib/target-supports.exp
> (check_effective_target_arm_neon_fp16_hw_ok): New.
> ---
> .../aarch64/advsimd-intrinsics/vcvt_f16.c | 98 ++++++++++++++++++++++
> gcc/testsuite/lib/target-supports.exp | 15 ++++
> 2 files changed, 113 insertions(+)
> create mode 100644 gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcvt_f16.c
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcvt_f16.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcvt_f16.c
> new file mode 100644
> index 0000000..a2cfd38
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcvt_f16.c
> +#include <math.h>
We should avoid dependencies on external header files. In this case I
can't see that anything in math.h is needed any way. Otherwise OK with
me.
/Marcus