This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4, wip] remove references to ganglocal shared memory inside gcc
- From: Cesar Philippidis <cesar at codesourcery dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Tom de Vries <Tom_deVries at mentor dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan_sidwell at mentor dot com>
- Date: Fri, 18 Sep 2015 06:51:18 -0700
- Subject: Re: [gomp4, wip] remove references to ganglocal shared memory inside gcc
- Authentication-results: sourceware.org; auth=none
- References: <55DE69C3 dot 4060707 at codesourcery dot com> <55E5D283 dot 8080105 at mentor dot com> <87y4g415qi dot fsf at kepler dot schwinge dot homeip dot net>
On 09/18/2015 01:39 AM, Thomas Schwinge wrote:
> On Tue, 1 Sep 2015 18:29:55 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote:
>> On 27/08/15 03:37, Cesar Philippidis wrote:
>>> - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align);
>>
>> I suspect this caused a bootstrap failure (align_and_expand unused).
>> Worked-around as attached.
>
>> --- a/gcc/omp-low.c
>> +++ b/gcc/omp-low.c
>> @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb)
>>
>> /* Modify the old size *POLDSZ to align it up to ALIGN, and then return
>> a value with SIZE added to it. */
>> -static tree
>> +static tree ATTRIBUTE_UNUSED
>> align_and_expand (tree *poldsz, tree size, unsigned int align)
>> {
>> tree oldsz = *poldsz;
>
> If I remember correctly, this has only ever been used in the "ganglocal"
> implementation -- which is now gone. So, should align_and_expand also be
> elided (Cesar)?
Most likely. I probably overlooked it when I was working on that
ganglocal removal patch. Can you remove it please? I'm already juggling
a couple of patches right now.
Thanks,
Cesar