This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR 57195] Allow mode iterators inside angle brackets
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: Michael Collison <michael dot collison at linaro dot org>
- Cc: gcc Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 17 Sep 2015 20:31:53 +0100
- Subject: Re: [PATCH, PR 57195] Allow mode iterators inside angle brackets
- Authentication-results: sourceware.org; auth=none
- References: <55DC37D4 dot 9050900 at linaro dot org> <8737yq5zpx dot fsf at e105548-lin dot cambridge dot arm dot com> <55F0C66F dot 8010205 at linaro dot org> <874mix2vky dot fsf at e105548-lin dot cambridge dot arm dot com> <55FA0072 dot 3060006 at linaro dot org>
Michael Collison <michael.collison@linaro.org> writes:
> On 09/14/2015 02:34 AM, Richard Sandiford wrote:
>> Michael Collison <michael.collison@linaro.org> writes:
>>> Here is a modified patch that takes your comments into account. Breaking
>>> on depth == 0 with '>' does not work due to the code looking for whitespace.
>> What goes wrong? Just to make sure we're talking about the same thing,
>> I meant that in:
>>
>> (match_operand:FOO> ...
>>
>> the name should be "FOO" and you should get an error on ">" when parsing
>> the text after the name, just like you would for:
>>
>> (match_operand:FOO] ...
>
> When I try breaking on '>' with a nesting depth of 0 all examples of
> <FOO> fail.
I meant break when depth == 0 before the decrement that's associated
with '>'. I think that problem would only occur if you broke _after_
decrementing the depth.
>> It's not a big deal though, so...
>>
>>> 2015-08-25 Michael Collison <michael.collison@linaro.org>
>>>
>>> PR other/57195
>>> * read-md.c (read_name): Allow mode iterators inside angle
>>> brackets in rtl expressions.
>> OK, thanks.
> Meaning okay to check the patch in?
Yeah, it's OK to check in.
Richard