This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Clean up arm_option_params_internals macro settings for attribute/pragma targets

From: Christian Bruel <christian dot bruel at st dot com>
To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 16 Sep 2015 08:58:26 +0200
Subject: Re: [PATCH, ARM] Clean up arm_option_params_internals macro settings for attribute/pragma targets
Authentication-results: sourceware.org; auth=none
References: <55F68DD6 dot 7080102 at st dot com> <55F7E7F9 dot 8000702 at arm dot com>



On 09/15/2015 11:42 AM, Kyrill Tkachov wrote:

Hi Christian,

On 14/09/15 10:05, Christian Bruel wrote:

Hi,

Prior sending the remaining target attributes, I'd like to simplify a
few chunks (thinko) that were unnecessary complicated :  The options
checks in arm_option_params_internal can't be from another context than
global_options.


Hmmm... I agree. TARGET_SET_CURRENT_FUNCTION will restore
the target options node into the global options and call
arm_option_params_internal, which can assume it operates
on the global options.

This patch is ok but...


Also add TARGET_OPTION_PRINT, small enough chunk to slip here I hope.


Please split this out into a separate patch with a separate ChangeLog entry.
Such a patch is pre-approved as long as the implementation of TARGET_OPTION_PRINT
is the same as in this patch.

Thanks,
Kyrill


OK Committed @ resp r227794 and r227795


Testing OK,

Thanks

Christian

References:
- [PATCH, ARM] Clean up arm_option_params_internals macro settings for attribute/pragma targets
  - From: Christian Bruel
- Re: [PATCH, ARM] Clean up arm_option_params_internals macro settings for attribute/pragma targets
  - From: Kyrill Tkachov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]