This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] COMDAT Safe Module Level Multi versioning

From: Sriraman Tallam <tmsriram at google dot com>
To: Cary Coutant <ccoutant at gmail dot com>
Cc: Xinliang David Li <davidxl at google dot com>, Richard Biener <richard dot guenther at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, binutils <binutils at sourceware dot org>, Yury Gribov <y dot gribov at samsung dot com>
Date: Wed, 9 Sep 2015 16:01:44 -0700
Subject: Re: [RFC] COMDAT Safe Module Level Multi versioning
Authentication-results: sourceware.org; auth=none
References: <CAAs8HmyB5jZS_zfHKeX9HEK3Eo59nVhuB4yfoGTy5hXV41YZYA at mail dot gmail dot com> <CAFiYyc1b++CR5FJBG4cFTZ2ec+dWgxXgoYWP72GWHtQ8BPruLg at mail dot gmail dot com> <CAAkRFZK3kgRbtCVTU7z04ugxSSCqmm_BA+Y=fW=MqnjNcV21Tg at mail dot gmail dot com> <CAAs8HmzY-YPt2bE6ce7S68Uh42KvfOZfLyMzT-N8JTFMbu9yPg at mail dot gmail dot com> <CAAs8HmwfrRfVuSU4iorW7ETscxxf4WqGx1qr+9+VeZ0Fe7xQKQ at mail dot gmail dot com> <CAAs8HmyoUAawcggMC7NU-LO4186vM2D4KL+xkA81PWdO32BXPg at mail dot gmail dot com> <CAAs8HmyVjF+cG10euUFNMZoLP6nV4V8nvqmCbNwSMgJr926C-Q at mail dot gmail dot com> <CAJimCsGMs5B0ZbFRYo5Ju5OrBxxvUz74Xwp51-VmUCWXpobLmA at mail dot gmail dot com> <CAAs8HmwE5hBCv2H6g-o0QyBNSqS6c3Mhr=JCS+iNFMV=Q7=8bA at mail dot gmail dot com> <CAJimCsF0uaxVKGTiHxTAW0yZgp57eCPj96-iFDACJ64_-CF_kg at mail dot gmail dot com> <CAAs8HmzQWwzRN8pObmtQyPB+yAHvS2xK-vDTZeD-k2JMVnn33Q at mail dot gmail dot com>

On Wed, Sep 2, 2015 at 4:32 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>
> On Tue, Aug 18, 2015 at 9:46 PM, Cary Coutant <ccoutant@gmail.com> wrote:
> >> Thanks, will make those changes.  Do you recommend a different name
> >> for this flag like -fmake-comdat-functions-static?
> >
> > Well, the C++ ABI refers to this as "vague linkage." It may be a bit
> > too long or too ABI-specific, but maybe something like
> > -f[no-]use-vague-linkage-for-functions or
> > -f[no-]functions-vague-linkage?
>
> Done and patch attached.


<Re-sending as plain text>
Ping.

* c-family/c.opt (fvague-linkage-functions): New option.
* cp/decl2.c (comdat_linkage): Implement new option.  Warn when
virtual comdat functions are seen.
* ipa.c (function_and_variable_visibility): Check for no vague
linkage.
* doc/invoke.texi: Document new option.
* testsuite/g++.dg/no-vague-linkage-functions-1.C: New test.

>
>
> * c-family/c.opt (fvague-linkage-functions): New option.
> * cp/decl2.c (comdat_linkage): Implement new option.  Warn when
> virtual comdat functions are seen.
> * ipa.c (function_and_variable_visibility): Check for no vague
> linkage.
> * doc/invoke.texi: Document new option.
> * testsuite/g++.dg/no-vague-linkage-functions-1.C: New test.
>
>
>
>
> >
> > And perhaps note in the doc that using this option may technically
> > break the C++ ODR, so it should be used only when you know what you're
> > doing.
>
> Done.
>
> Thanks
> Sri
>
> >
> > -cary

Attachment: no_vague_linkage_functions.txt
Description: Text document

References:
- Re: [RFC] COMDAT Safe Module Level Multi versioning
  - From: Sriraman Tallam

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]