This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Jonathan Roelofs <jonathan at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Kostya Serebryany <kcc at google dot com>
- Date: Wed, 9 Sep 2015 23:20:26 +0800
- Subject: Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.
- Authentication-results: sourceware.org; auth=none
- References: <55DF92B6 dot 6020802 at codesourcery dot com> <55E87206 dot 6030500 at codesourcery dot com> <20150903161711 dot GY1847 at tucnak dot redhat dot com> <55E8792A dot 8010909 at codesourcery dot com> <C2DCFF6D-22F2-40EC-B691-99CFCD22E9A9 at comcast dot net>
On Wed, Sep 9, 2015 at 11:11 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Sep 3, 2015, at 9:45 AM, Jonathan Roelofs <jonathan@codesourcery.com> wrote:
>> Moral of the story is: these tests fail in our environment, but only because the regexes do not expect the presence of the ansi color codes, and we can't trick the runtime into not emitting them.
>
> When the user says, I donât want color; is color emitted? If so, thatâs a bug, and needs to be fixed. If the user can, then, dejagnu can. When it says, donât use color, that should be respected; just as if the user had said it. Anyway, a | decolor more a la prune should be able to remove color, even if there were no other way.
The issue is dejagnu cannot (at least in the current implementation of
the remotes), cannot set an env that stays alive before invoking the
program (though maybe it could use the env program to do the
invoking).
>
> Iâm not a fan of the changes as is.