This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Do not ifcvt complex blocks if the else block is empty
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
- Date: Wed, 09 Sep 2015 11:18:44 +0200
- Subject: Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Do not ifcvt complex blocks if the else block is empty
- Authentication-results: sourceware.org; auth=none
- References: <55EDBB73 dot 5080900 at arm dot com> <yddk2s1dzxz dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <55EF10D4 dot 6050909 at arm dot com>
Kyrill Tkachov <kyrylo.tkachov@arm.com> writes:
> On 08/09/15 10:26, Rainer Orth wrote:
>> Hi Kyrill,
>>
>>> PR rtl-optimization/67481 is a testsuite regression on sparc-solaris that
>>> Rainer reported. I haven't tested
>>> that this patch fixes that, but I suspect that the root cause is the
>>> same. Rainer, could you please
>>> check that this fixes the regression for you?
>> I've now checked that with your patch the regression went away indeed,
>> using a limited non-bootstrap build on sparc-sun-solaris2.10. Next I'll
>> run a full bootstrap to check there are no other issues.
>
> After some more benchmarking I've noticed that this patch is overly restrictive
> in some cases. I have a prototype patch that fixes the regressions and does not
> restrict if-conversion too much.
>
> I need to do some more testing, and hope to post it in due time.
FWIW, the bootstrap with your original patch has now completed
successfully, the only change being that the testsuite failures are
gone.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University