This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow
- From: Charles Baylis <charles dot baylis at linaro dot org>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: Jeff Law <law at redhat dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Kyrylo Tkachov <kyrylo dot tkachov at arm dot com>, Richard Earnshaw <rearnsha at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 7 Sep 2015 09:35:20 +0100
- Subject: Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow
- Authentication-results: sourceware.org; auth=none
- References: <CADnVucBy-31ETtJW9K20u_Q=7fhmFjh1gL7daH_+y=JoJ0hxyg at mail dot gmail dot com> <55E611D3 dot 90704 at redhat dot com> <20150902120917 dot GB6869 at kam dot mff dot cuni dot cz>
On 2 September 2015 at 13:09, Jan Hubicka <hubicka@ucw.cz> wrote:
> It kind of sucks that one needs to mind this flag each time one creates edge,
> but setting the value in create_edge is not quite correct as that one does not
> have any information on where the call appears and if the exception is not handled
> locally.
OK.
>> >gcc/ChangeLog:
>> >
>> >2015-08-28 Charles Baylis <charles.baylis@linaro.org>
>> >
>> > * cgraphunit.c (cgraph_node::create_wrapper): Set can_throw_external
>> > in new callgraph edge.
>> Ultimately Jan's call.
>
> This is OK.
> Thanks for looking into this!
Thanks for the review!
FWIW, the patch successfully bootstrapped on arm-linux-gnueabihf
Committed to trunk as r227407.
Are you happy for me to backport to gcc-5-branch?
Charles