This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 60586
- From: Jeff Law <law at redhat dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: "Zamyatin, Igor" <igor dot zamyatin at intel dot com>
- Date: Wed, 2 Sep 2015 14:55:53 -0600
- Subject: Re: [PATCH] PR 60586
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003B0F002A at fmsmsx101 dot amr dot corp dot intel dot com> <55E62613 dot 7060706 at redhat dot com> <BF230D13CA30DD48930C31D4099330003B0F1015 at fmsmsx101 dot amr dot corp dot intel dot com>
On 09/01/2015 10:30 PM, Iyer, Balaji V wrote:
Hi Jeff,
I thought about this for a minute and I don't think I need to use the lang_hooks. I could do this change right before calling gimplify_cilk_spawn. I have attached the fixed patch and have answered your questions below. Here are the ChangeLog entries:
gcc/c-family/ChangeLog:
2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
PR middle-end/60586
* c-common.h (cilk_gimplify_call_params_in_spawned_fn): New prototype.
* c-gimplify.c (c_gimplify_expr): Added a call to the function
cilk_gimplify_call_params_in_spawned_fn.
* cilk.c (cilk_gimplify_call_params_in_spawned_fn): New function.
(gimplify_cilk_spawn): Removed EXPR_STMT and CLEANUP_POINT_EXPR
unwrapping.
gcc/cp/ChangeLog
2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
PR middle-end/60586
* cp-gimplify.c (cilk_cp_gimplify_call_params_in_spawned_fn): New
function.
(cp_gimplify_expr): Added a call to the function
cilk_cp_gimplify_call_params_in_spawned_fn.
gcc/testsuite/ChangeLog
2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
PR middle-end/60586
* c-c++-common/cilk-plus/CK/pr60586.c: New file.
* g++.dg/cilk-plus/CK/pr60586.cc: Likewise.
Is this OK for trunk?
Yes. Please install.
Thanks,
Jeff