This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4] New reduction infrastructure for OpenACC
- From: Tom de Vries <Tom_deVries at mentor dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan_sidwell at mentor dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Tue, 1 Sep 2015 14:53:14 +0200
- Subject: Re: [gomp4] New reduction infrastructure for OpenACC
- Authentication-results: sourceware.org; auth=none
- References: <55D4DC16 dot 7020106 at codesourcery dot com>
On 19/08/15 21:42, Cesar Philippidis wrote:
+DEFHOOK
+(reduction,
+"This hook is used by the oacc_transform pass to expand calls to the\n\
+internal functions @var{GOACC_REDUCTION_SETUP},\n\
+@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\
+sequence introduces any calls to OpenACC-specific internal functions.",
+bool, (gimple call),
+default_goacc_reduction)
+
This causes a gomp-4_0-branch bootstrap error:
...
src/gcc/target.def:1685:1: error: unknown escape sequence: '\040' [-Werror]
...
Currently testing attached patch, which allows 'make build/genhooks.o'
to succeed.
Thanks,
- Tom
--- gcc/target.def 2015-09-01 01:45:41.851372425 -0700
+++ gcc/target.def 2015-09-01 05:41:48.280961137 -0700
@@ -1684,7 +1684,13 @@
(reduction,
"This hook is used by the oacc_transform pass to expand calls to the\n\
internal functions @var{GOACC_REDUCTION_SETUP},\n\
-@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\
+@var{GOACC_REDUCTION_INIT},\n\
+@var{GOACC_REDUCTION_FINI} and\n\
+@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\
+@var{call} is gimple statement containing the call to the function. This\n\
+hook removes statement @var{call} after the expanded sequence has been\n\
+inserted. This hook is also responsible for allocating any storage for\n\
+reductions when necessary. It returns @var{true} if the expanded\n\
sequence introduces any calls to OpenACC-specific internal functions.",
bool, (gimple call),
default_goacc_reduction)