This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC AArch64][PR 63304] Handle literal pools for functions > 1 MiB in size.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, James Greenhalgh <james dot greenhalgh at arm dot com>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Date: Thu, 27 Aug 2015 15:07:30 +0100
- Subject: Re: [RFC AArch64][PR 63304] Handle literal pools for functions > 1 MiB in size.
- Authentication-results: sourceware.org; auth=none
- References: <20150727143235 dot GA19415 at e105545-lin>
On 27 July 2015 at 15:33, Ramana Radhakrishnan
<ramana.radhakrishnan@foss.arm.com> wrote:
> <DATE> Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> PR target/63304
> * config/aarch64/aarch64.c (aarch64_expand_mov_immediate): Handle
> nopcrelative_literal_loads.
> (aarch64_classify_address): Likewise.
> (aarch64_constant_pool_reload_icode): Define.
> (aarch64_secondary_reload): Handle secondary reloads for
> literal pools.
> (aarch64_override_options): Handle nopcrelative_literal_loads.
> (aarch64_classify_symbol): Handle nopcrelative_literal_loads.
> * config/aarch64/aarch64.md (aarch64_reload_movcp<ALLTF:mode><P:mode>):
> Define.
> (aarch64_reload_movcp<VALL:mode><P:mode>): Likewise.
> * config/aarch64/aarch64.opt: New option mnopc-relative-literal-loads
> * config/aarch64/predicates.md (aarch64_constant_pool_symref): New
> predicate.
> * doc/invoke.texi (mnopc-relative-literal-loads): Document.
This looks OK to me. It needs rebasing, but OK if the rebase is
trival. Default on is fine. Hold off on the back ports for a couple
of weeks.
Cheers
/Marcus