This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jason Merrill <jason at redhat dot com>, Markus Trippelsdorf <markus at trippelsdorf dot de>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Fri, 21 Aug 2015 19:11:32 +0200
Subject: Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
Authentication-results: sourceware.org; auth=none
References: <55D4DD2D dot 3070500 at oracle dot com> <20150821061830 dot GB399 at x4> <20150821063050 dot GC399 at x4> <55D6E691 dot 1000308 at oracle dot com> <55D6EA2C dot 2090400 at oracle dot com> <55D745AB dot 2070000 at redhat dot com>

Hi,

On 08/21/2015 05:37 PM, Jason Merrill wrote:

On 08/21/2015 05:06 AM, Paolo Carlini wrote:

    if (DECL_NAME (decl)
        && MAIN_NAME_P (DECL_NAME (decl))
-      && CP_DECL_CONTEXT (decl) == global_namespace)
+      && CP_DECL_CONTEXT (decl) == global_namespace
+      && !at_function_scope_p ())

How about looking at the "scope" local variable instead ofCP_DECL_CONTEXT?

Ah nice. Simply checking:

    scope == global_namespace

appears to work great. Shall I go with that if testing is fine?

Thanks!
Paolo.

Follow-Ups:
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Jason Merrill

References:
- [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Paolo Carlini
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Markus Trippelsdorf
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Markus Trippelsdorf
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Paolo Carlini
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Paolo Carlini
- Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]